docs(bindings): fix client hello doc tests #4495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- gate first doc test behind a configure module - modify other doc tests to use default features
jmayclin
changed the title
lrstewart
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
cargo testcurrently fails on mainline bindings because the doc tests fail. This is because some of the configuring functionality was refactored in #4474 .This PR
cargo testclient_hello.rsto a feature-gated moduleconnection.rsto only use non-gated methods.Testing:
More CI was added to prevent a regression.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.