fix: Python integ tests are flaky on arm #4512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatgoose
approved these changes
Apr 23, 2024
lrstewart
reviewed
Apr 24, 2024
lrstewart
reviewed
Apr 25, 2024
lrstewart
approved these changes
Apr 25, 2024
goatgoose
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
N/A
Description of changes:
Prepends some bytes of previously seen stdout to the newest chunk on stdout data. This ensures send markers don't get stuck in-between two chunks and never seen.
Call-outs:
There's a couple of other fixes in the processes.py file to make the debugging output more accurate.
Testing:
I'm rerunning this test as much as I can, so far I'm on 5 reruns without seeing a failure. So I'm feeling good that the flakiness is fixed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.