chore(bindings): Pin zeroize to avoid MSRV increase
#4519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmayclin
approved these changes
Apr 24, 2024
| @@ -45,3 +45,4 @@ cc = { version = "1.0", features = ["parallel"] } | |||
| jobserver = "=0.1.26" # newer versions require rust 1.66, see https://github.com/aws/s2n-tls/issues/4241 | |||
| home = "=0.5.5" # newer versions require rust 1.70, see https://github.com/aws/s2n-tls/issues/4395 | |||
| regex = "=1.9.6" # newer versions require rust 1.65, see https://github.com/aws/s2n-tls/issues/4242 | |||
| zeroize = "=1.7.0" # newer versions require rust 1.72, see https://github.com/aws/s2n-tls/issues/4518 | |||
There was a problem hiding this comment.
nit: This isn't really a PR issue, but maybe it would make sense to have a single tracking issue with the pins rather than making a new pin for each one? And just keep the list sorted by "required MSRV"?
There was a problem hiding this comment.
Yeah that makes sense. I will merge this first though to unblock the CI. #4521
maddeleine
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The
zeroizecrate has updated their MSRV to 1.72 which causes the rust bindings build to fail, see #4518. This PR pinszeroizeto the previous version in order to avoid the MSRV increase.Testing:
The CI should build the rust bindings successfully.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.