binding: Add s2n_connection_get_session on the Connection #4522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
reviewed
Apr 25, 2024
jmayclin
reviewed
Apr 25, 2024
lrstewart
reviewed
Apr 26, 2024
Comment on lines
682
to
683
| /// Retrieves the size of the session ticket. | ||
| pub fn session_ticket_length(&mut self) -> Result<usize, Error> { |
There was a problem hiding this comment.
Should this be &mut self or just &self? Is this mutating?
Same for session_ticket
There was a problem hiding this comment.
No, it doesn't. Reading the c side, I think it should be safe to make it &self.
I was mainly unsure initially because of tls1.3, where these tickets can change if io is in progress.
jmayclin
approved these changes
Apr 29, 2024
camshaft
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
N/A
Description of changes:
The change adds a new method in the
Connectionfor the rust bindings to expose the session state. This allows clients/servers to capture the most recent session outside of theSessionTicketCallbackcallback.Until #4264 is addressed, this allows sessions for TLS1.2 or lower to be cached with data other than a servername.
Call-outs:
The C api requires an allocation for writing the session, In order to provide a simpler rust API, and be consistent with some of the other apis in Connection, the buffer allocation is performed within the
connection::sessionmethod itself.Testing:
Unit tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.