Skip to content

Commit

Permalink
Merge pull request #188 from leoroy/mix-case-fix
Browse files Browse the repository at this point in the history
fix: fix the trial-component loading issue for jobs with mix-case name
  • Loading branch information
leoroy committed May 3, 2023
2 parents 45494f8 + 1146fb2 commit cbdb7ef
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/smexperiments/_environment.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def get_trial_component(self, sagemaker_boto_client):
while time.time() - start < 300:
summaries = list(
trial_component.TrialComponent.list(
source_arn=self.source_arn.lower(), sagemaker_boto_client=sagemaker_boto_client
source_arn=self.source_arn, sagemaker_boto_client=sagemaker_boto_client
)
)
if summaries:
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_environment.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def test_resolve_trial_component(training_job_env, sagemaker_boto_client):
tc = environment.get_trial_component(sagemaker_boto_client)

assert trial_component_name == tc.trial_component_name
sagemaker_boto_client.list_trial_components.assert_called_with(SourceArn="arn:1234abcde")
sagemaker_boto_client.list_trial_components.assert_called_with(SourceArn="arn:1234aBcDe")
sagemaker_boto_client.describe_trial_component.assert_called_with(TrialComponentName=trial_component_name)


Expand Down

0 comments on commit cbdb7ef

Please sign in to comment.