Skip to content

Commit

Permalink
change: remove hardcoded creds from integ test (#1029)
Browse files Browse the repository at this point in the history
  • Loading branch information
laurenyu committed Sep 6, 2019
1 parent c364fd1 commit 1316b63
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tests/integ/test_git.py
Original file line number Diff line number Diff line change
Expand Up @@ -233,14 +233,15 @@ def test_git_support_with_sklearn_ssh_passphrase_not_configured(


@pytest.mark.local_mode
@pytest.mark.skip("needs a secure authentication approach")
def test_git_support_codecommit_with_mxnet(sagemaker_local_session):
script_path = "mnist.py"
data_path = os.path.join(DATA_DIR, "mxnet_mnist")
git_config = {
"repo": CODECOMMIT_REPO,
"branch": CODECOMMIT_BRANCH,
"username": "GitTest-at-142577830533",
"password": "22LcZpWMtjpDG3fbOuHPooIoKoRxF36rQj7zdUvXooA=",
"password": "", # TODO: assume a role to get temporary credentials
}
source_dir = "mxnet"
dependencies = ["foo/bar.py"]
Expand Down

0 comments on commit 1316b63

Please sign in to comment.