Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing Dependencies #52

Closed
cgarciae opened this issue Jan 21, 2018 · 5 comments
Closed

Installing Dependencies #52

cgarciae opened this issue Jan 21, 2018 · 5 comments

Comments

@cgarciae
Copy link

cgarciae commented Jan 21, 2018

Hi! I am using Deep Mind's Sonnet library to make my architecture code reusable. Sonnet is not included in the py2 container and I have not found a way to pass additional requirements to SageMaker. Could you implement a way to pass a requirements.txt file to the Tensorflow constructor so SageMaker installs the requirements in the Docker container before training? Floydhub lets you define the floyd_requirements.txt file that does exactly this and works very well.

@owen-t
Copy link
Contributor

owen-t commented Jan 22, 2018

Hi,

Thanks for the feature suggestion! This is something I've previously thought would be really cool and it would be great to get this into our SDK. We'll post here when the feature is released.

@cgarciae
Copy link
Author

Excellent! Looking forward to it.

For anyone interested, I've resorted to installing dependencies from python, just add these lines before all other imports:

from subprocess import call
call("pip install dm-sonnet".split(" "))

@laurenyu laurenyu added status: pending release The fix have been merged but not yet released to PyPI and removed In progress labels Mar 2, 2018
@nadiaya nadiaya removed the status: pending release The fix have been merged but not yet released to PyPI label Mar 7, 2018
@nadiaya
Copy link
Contributor

nadiaya commented Mar 7, 2018

This feature has been released.

@Jacob-Stevens-Haas
Copy link

Hey, not sure if I'm doing it wrong, or if "feature released" is only python2 (which was the OP's version).

I open terminal pip install geopy. Asked some AWS folks at an event and they said to install from within notebook, because the instance of Python is specific to the notebook. That doesn't work in normal notebooks, but, hey look, it still doesn't work. @cgarciae's trick does. Is that supposed to be how we install them?

apacker pushed a commit to apacker/sagemaker-python-sdk that referenced this issue Nov 15, 2018
@dshahrokhian
Copy link

Is this feature only working with tensorflow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants