Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/putting it all together #4522

Draft
wants to merge 58 commits into
base: master-jumpstart-curated-hub
Choose a base branch
from

Conversation

bencrabtree
Copy link
Collaborator

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jinyoung-lim and others added 30 commits March 8, 2024 17:35
bencrabtree and others added 11 commits March 21, 2024 14:04
* first pass at sync function with util classes

* adding tests and update clases

* linting

* file generator class inheritance

* lint

* multipart copy and algorithm updates

* modularize sync

* reformatting folders

* testing for sync

* do not tolerate vulnerable

* remove prints

* handle multithreading progress bar

* update tests

* optimize function and add hub bucket prefix

* docstrings and linting
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 57.71605% with 274 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (master-jumpstart-curated-hub@74bbb09). Click here to learn what that means.

❗ Current head 2f22365 differs from pull request most recent head 3c986f6. Consider uploading reports for the commit 3c986f6 to get more accurate results

Files Patch % Lines
src/sagemaker/jumpstart/types.py 56.40% 235 Missing ⚠️
src/sagemaker/jumpstart/converter_utils.py 61.11% 21 Missing ⚠️
src/sagemaker/jumpstart/cache.py 28.57% 10 Missing ⚠️
src/sagemaker/jumpstart/curated_hub/curated_hub.py 50.00% 7 Missing ⚠️
src/sagemaker/jumpstart/enums.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##             master-jumpstart-curated-hub    #4522   +/-   ##
===============================================================
  Coverage                                ?   86.68%           
===============================================================
  Files                                   ?      398           
  Lines                                   ?    37768           
  Branches                                ?        0           
===============================================================
  Hits                                    ?    32741           
  Misses                                  ?     5027           
  Partials                                ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 2f22365
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 3c986f6
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants