Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema dependency version #4540

Merged
merged 3 commits into from Mar 26, 2024
Merged

Conversation

zhaoqizqwang
Copy link
Contributor

@zhaoqizqwang zhaoqizqwang commented Mar 26, 2024

Update schema package to force the version to be 0.7.5 to avoid test failures. Schema is not an actively updated package. Checked with clarify team and it's ok to pin the version to 0.7.5

Issue #, if available:

Description of changes:

*Testing done: No further test needed.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Update schema package to force the version to be 0.7.5 to avoid test failures
@zhaoqizqwang zhaoqizqwang requested a review from a team as a code owner March 26, 2024 20:08
@zhaoqizqwang zhaoqizqwang requested review from liujiaorr and removed request for a team March 26, 2024 20:08
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.38%. Comparing base (959cb0f) to head (201883f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4540   +/-   ##
=======================================
  Coverage   87.38%   87.38%           
=======================================
  Files         389      389           
  Lines       36776    36776           
=======================================
  Hits        32135    32135           
  Misses       4641     4641           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaoqizqwang
Copy link
Contributor Author

/bot run pr

@zhaoqizqwang
Copy link
Contributor Author

/bot run all

@akrishna1995 akrishna1995 self-requested a review March 26, 2024 21:18
@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 201883f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@zhaoqizqwang zhaoqizqwang merged commit 74c624a into aws:master Mar 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants