Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master benchmark feature merge master #4661

Conversation

makungaj1
Copy link
Collaborator

@makungaj1 makungaj1 commented May 7, 2024

Issue #, if available:

Description of changes:
Merge master.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [x ] I have read the CONTRIBUTING doc
  • [ x] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • [x ] I used the commit message format described in CONTRIBUTING
  • [x ] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • [ x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • [ x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [x ] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • [x ] I have checked that my tests are not configured for a specific region or account (if appropriate)
  • [x ] I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Captainia and others added 30 commits April 23, 2024 09:03
* fix: parsing

* fix: commit tests

* fix: types

* updated

* fix
Co-authored-by: Nikhil Kulkarni <nikhilsk@amazon.com>
* feature: support session tag chaining for training job

* fix: resolve typo

* fix: resolve typo and build failure

* fix: resolve typo and unit test failure

---------

Co-authored-by: Jessica Zhu <jessicazhu3@106775307+jessicazhu3@users.noreply.github.com>
* breaking: set default allow_pickle param to False

* breaking: fix unit tests and linting

NumpyDeserializer will not allow deserialization
unless allow_pickle flag is set to True explicitly

* fix: black-check

---------

Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
* fix: invalid component name

* tests

* format

* fix vulnerable model integ tests llama 2

* updated

* fix: training dataset location
* Update skipped flaky tests

* flake8

* format

* format
* chore: release tgi 2.0.1

* minor fix

---------

Co-authored-by: Zhaoqi <52220743+zhaoqizqwang@users.noreply.github.com>
* Add ReadOnly APIs

* Resolving PR review comments

* Resolve PR review comments

* Refactoring

* Refactoring

* Add Caching

* Refactore

* Resolving conflicts

* Add Unit Tests

* Fix Unit Tests

* Fix unit tests

* Fix UT

* Refactoring

* Fix Integ tests

* refactoring after Notebook testing

* Fix code styles

---------

Co-authored-by: Jonathan Makunga <makung@amazon.com>
* tag config name

* format

* resolving comments

* format

* format

* update

* fix

* format

* updates inference component config name

* fix: tests
…ws#4614)

* Add funtionalities to get and set deployment config

* Resolve PR comments

* ModelBuilder-JS

* Add Unit tests

* Refactoring

* Testing with Notebook

* Test backward compatibility

* Remove Accelerated column if all not enabled

* Fix docstring

* Resolved PR Review comments

* Docstring

* increase code coverage

---------

Co-authored-by: Jonathan Makunga <makung@amazon.com>
* Add funtionalities to get and set deployment config

* Resolve PR comments

* ModelBuilder-JS

* Add Unit tests

* Refactoring

* Testing with Notebook

* Test backward compatibility

* Remove Accelerated column if all not enabled

* Fix docstring

* Resolved PR Review comments

* Docstring

* increase code coverage

* Testing fix with Notebook

* Only fetch instance rate metrics if not present

* Increase code coverage

---------

Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: Jonathan Makunga <makung@amazon.com>
…aws#4625)

* require config_name and instance_type in set config

* docstring

* add supported instance types check

* add more tests

* format

* fix tests
* Init Deployment configs outside Model init.

* Testing with NB

* Testing with NB-V2

* Refactoring, NB testing

* NB Testing and Refactoring

* Testing

* Refactoring

* Testing with NB

* Debug

* Debug display API

* Debug with NB

* Testing with NB

* Refactoring

* Refactoring

* Refactoring and NB testing

* Testing with NB

* Refactoring

* Prefix instance type with ml

* Fix unit tests

---------

Co-authored-by: Jonathan Makunga <makung@amazon.com>
* Use separate tags for inference and training

* format

* format

* format

* format
* Filter down Benchmark Metrics

* Filter down Benchmark Metrics

* Testing NB

* Testing MB

* Testing

* Refactoring

* Unit tests

* Display instance type first, and instance rate last

* Display unbalanced metrics

* Testing with NB

* Testing with NB

* Debug

* Debug

* Testing with NB

* Testing with NB

* Testing with NB

* Refactoring

* Refactoring

* Refactoring

* Unit tests

* Custom lru

* Custom lru

* Custom lru

* Custom lru

* Custom lru

* Custom lru

* Custom lru

* Custom lru

* Custom lru

* Custom lru

* Refactoring

* Debug

* Config ranking

* Debug

* Debug

* Debug

* Debug

* Debug

* Ranking

* Ranking-Debug

* Ranking-Debug

* Ranking-Debug

* Ranking-Debug

* Ranking-Debug

* Ranking-Debug

* Debug

* Debug

* Debug

* Debug

* Refactoring

* Contact JumpStart team to fix flaky test. test_list_jumpstart_models_script_filter

---------

Co-authored-by: Jonathan Makunga <makung@amazon.com>
@makungaj1 makungaj1 marked this pull request as ready for review May 7, 2024 21:36
@makungaj1 makungaj1 requested a review from a team as a code owner May 7, 2024 21:36
@makungaj1 makungaj1 requested review from pintaoz-aws and removed request for a team May 7, 2024 21:36
@evakravi evakravi merged commit ad30b85 into aws:master-benchmark-feature May 7, 2024
11 checks passed
@makungaj1 makungaj1 deleted the master-benchmark-feature-merge-master branch May 8, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants