Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: jumpstart telemetry #4697

Merged
merged 7 commits into from
Jun 5, 2024
Merged

Conversation

evakravi
Copy link
Member

@evakravi evakravi commented May 21, 2024

Issue #, if available:

Description of changes:
Adds a user agent heading to training jobs, endpoints, and invoke_endpoint api calls made with JumpStart models.

Testing done:
Pending

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@evakravi evakravi requested a review from a team as a code owner May 21, 2024 16:08
@evakravi evakravi requested review from Aditi2424 and removed request for a team May 21, 2024 16:08
@knikure knikure self-requested a review May 21, 2024 16:29
def get_jumpstart_user_agent_extra_suffix(model_id: str, model_version: str) -> str:
"""Returns the model-specific user agent string to be added to requests."""
sagemaker_python_sdk_headers = get_user_agent_extra_suffix()
jumpstart_specific_suffix = f"js_model_id/{model_id} js_model_version/{model_version}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make it a constant? Something like JUMPSTART_UA_SUFFIX = md/js_model_id#<id> js_model_ver#<version> This follows the guidelines of UserAgent string as shared in primate chat.

@knikure knikure self-assigned this Jun 5, 2024
@knikure knikure merged commit 5e43241 into aws:master Jun 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants