Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support image_config in Huggingface image #4700

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

njbrake
Copy link

@njbrake njbrake commented May 22, 2024

Allow for the container to be passed the image_config

Issue #, if available:

botocore.exceptions.ClientError: An error occurred (ValidationException) when calling the CreateModel operation: Using non-ECR image "" without Vpc repository access mode is not supported.

Description of changes:

Similar to what is done in sagemaker/model.py, pass in self.image_config to the sagemaker.container_def function
Testing done:
Tested locally

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [x ] I have read the CONTRIBUTING doc
  • [ x] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • [ x] I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Allow for the container to be passed the image_config
@njbrake njbrake requested a review from a team as a code owner May 22, 2024 19:10
@njbrake njbrake requested review from ptkab and removed request for a team May 22, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant