-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add selectable inference content for csv, json, jsonlines, and recordio-protobuf #111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is alarming that we are now dictating what the correct values to return to customers are, for example get label for binary_log. The decisions you made make sense to me, but we might want to involve product to make sure this behavior is ok to push out.
Also, were integration tests run with the built image?
Okay! Let's sync up on the product point. Most of the "correct value" decisions are just an extension of the xgboost sklearn API
Yep! Correct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small nit comments, LGTM
Description of changes:
application/json
,application/jsonlines
,application/x-recordio-protobuf
, andtext/csv
SAGEMAKER_INFERENCE_OUTPUT
enviornment variable.SAGEMAKER_INFERENCE_OUTPUT='predicted_label,probabilities'
Tested with
tox
and integration tests.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.