Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We've had customer feedback that
transform_fn
(where customers can combineinput_fn
,predict_fn
andoutput_fn
in a single function to handle inference requests) is lacking in xgboost. This PR enables the use oftransform_fn
in script mode.The actual code change to enable
transform_fn
is minimal in_user_module_transformer()
of src/sagemaker_xgboost_container/serving.py, so the review can be focused onserving.py
. The rest of the changes are for adding container tests for xgboost abalone script. The sample script attest/resources/abalone/abalone_distributed.py
is the same script from sagemaker examples for xgboost distributed training.After this PR is merged, the following text will be added to the Python SDK documentation after the section on
input_fn
,predict_fn
, andoutput_fn
:By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing
New container tests in this PR.
Existing integration tests succeeded.