Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin dependency versions for 1.0-1 #143

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

edwardjkim
Copy link
Contributor

@edwardjkim edwardjkim commented Oct 26, 2020

Description of changes:

Pins versions for all major dependencies. We have had too many issues related to Conda/Python/libraries getting upgraded inadvertently when a CodeBuild build is triggered. This PR pins the versions in requirements.txt to a specific version or puts an upper bound.

The versions were inspected with pip freeze:

docker run 246618743249.dkr.ecr.us-west-2.amazonaws.com/sagemaker-xgboost:1.0-1-cpu-py3 sh -c 'python -m pip freeze'

See also #140.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

@edmrossi edmrossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@edwardjkim edwardjkim merged commit c18776a into aws:1.0-1 Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants