Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstall typing for smdebug version bump #157

Merged
merged 5 commits into from
Feb 15, 2021

Conversation

edwardjkim
Copy link
Contributor

Description of changes:

sagemaker-containers (which is deprecated) installs typing which was necessary in Python 3.5 for typing support but is no longer necessary in Python 3.7. Install typing in Python 3.7 can result in conflicts, e.g., when installing python3 -m pip install black. The simplest solution is to uninstall typing at the end.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@edwardjkim
Copy link
Contributor Author

We are hitting docker pull rate limit:

Step 4/23 : FROM nvidia/cuda:${CUDA_VERSION}-base-ubuntu${UBUNTU_VERSION}@sha256:${IMAGE_DIGEST}
toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

@edwardjkim edwardjkim mentioned this pull request Feb 3, 2021
@edwardjkim edwardjkim merged commit 55bb455 into aws:master Feb 15, 2021
@edwardjkim edwardjkim deleted the uninstall_typing branch February 15, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants