Latest multiarch #209
Merged
Latest multiarch #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
awsbmillare
commented
Aug 10, 2021
•
awsbmillare
commented
- Fix conda version bump
- Add arm64 dockerfile for arm support and eventual multiarch support
added 2 commits
August 8, 2021 20:19
* needed for multiarch and graviton support * also version bump numpy installer workaround
aws-patlin
approved these changes
Aug 10, 2021
| ARG UBUNTU_VERSION=18.04 | ||
| ARG IMAGE_DIGEST=c60266b67f58fafc30703315f617a8fcccaffc48ef5534ca5f67a9ba3aceb3b8 | ||
|
|
||
| FROM ubuntu:18.04 |
There was a problem hiding this comment.
No cuda support on arm64?
There was a problem hiding this comment.
Nada. Current Graviton instances don't have NVidia GPUs anyways so not an issue for SageMaker customers but Graviton3 will have GPU support so this may change in the future.
There was a problem hiding this comment.
Regarding testing new dockerfile, I tested this locally (on a graviton instance) and built an arm64 image that passed unit and integ tests.
aws-patlin
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.