Swap version bump method for pip #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yusharon
reviewed
Aug 26, 2021
| @@ -103,7 +103,8 @@ RUN echo "conda ${CONDA_PKG_VERSION}" >> /miniconda3/conda-meta/pinned && \ | |||
| cmake --build . --target mlio-arrow && \ | |||
| cd ../../src/mlio-py && \ | |||
| python3 setup.py bdist_wheel && \ | |||
| conda update -y pip && \ | |||
| python3 -m pip install typing && \ | |||
There was a problem hiding this comment.
Can you explain why typing is needed here?
There was a problem hiding this comment.
apparently upgrading pip now causes it to complain about missing dependency 'typing'. When I install 'typing' first, it no longer complains. I'd rather fix the dependency now to remove the complaint instead of installing pip without 'typing' even if it works fine.
yusharon
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fix pip security vulnerability that was not addressed in previous commit.
Description of changes:
There was a faulty validation process that caused this to slip. Only using pip to upgrade pip works, using conda to update pip does not fix security vulnerability
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.