Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version to 1.5.2 && resolve feature name breaking #253

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

haixiw
Copy link
Contributor

@haixiw haixiw commented Mar 11, 2022

Issue #, if available:

Description of changes:
There is a breaking change between Xgboost 1.3.3 to version 1.5.2:

XGBoost used to generate some pseudo feature names within DMatrix
when inputs (like np.ndarray) don't already have column names. The procedure is removed to
avoid conflict with other inputs
DMLC SGBoost #6605

Our code is fully consistent with the open source XGBoost repo

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@haixiw haixiw requested a review from awsbmillare March 11, 2022 20:27
@awsbmillare
Copy link
Contributor

looks good but let's not merge right away, we need to make sure we have the other branch stuff working in case we need to make changes/develop for current 1.3

@awsbmillare awsbmillare merged commit 4ed9fe4 into master Mar 29, 2022
@awsbmillare awsbmillare deleted the 1.5.2-draft branch March 29, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants