Add accept encodings to alg_mode #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikhilRaverkar
added a commit
that referenced
this pull request
Apr 27, 2022
* Store ground truth and predictions on validation folds to output folder (#230) * Store ground truth and predictions on validation folds to output folder * Refactor functionality to store validation set predictions into a separate class * Update src/sagemaker_xgboost_container/prediction_utils.py Co-authored-by: Mark Bunday <15115482+mabunday@users.noreply.github.com> * Update src/sagemaker_xgboost_container/prediction_utils.py Co-authored-by: Mark Bunday <15115482+mabunday@users.noreply.github.com> * Update src/sagemaker_xgboost_container/prediction_utils.py Co-authored-by: Mark Bunday <15115482+mabunday@users.noreply.github.com> * Update src/sagemaker_xgboost_container/prediction_utils.py Co-authored-by: Mark Bunday <15115482+mabunday@users.noreply.github.com> * Update src/sagemaker_xgboost_container/prediction_utils.py Co-authored-by: Mark Bunday <15115482+mabunday@users.noreply.github.com> * Update src/sagemaker_xgboost_container/prediction_utils.py Co-authored-by: Mark Bunday <15115482+mabunday@users.noreply.github.com> * Add checks for recorded predictions, refactor helper functions * More accurate final repeated prediction counter check * Add unit tests for prediction_utils.py * Using data_root for kfold tests to reduce code duplication Co-authored-by: Iaroslav Shcherbatyi <siarosla@amazon.com> Co-authored-by: Mark Bunday <15115482+mabunday@users.noreply.github.com> * upgrading pillow to 9.0.0 to address high security risks from CVE https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-22817 https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-22816 https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-22815 * upgrading pillow to 9.0.0 to address high security risks from CVE https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-22817 https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-22816 https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-22815 * Using keyring to prevent GPG key from being outdated * Using keyring to prevent GPG key from being outdated * Bump numpy from 1.20.3 to 1.21.0 * Bump numpy from 1.20.3 to 1.21.0 * Bump numpy from 1.20.3 to 1.21.0 * bump up version to 1.5.2 * Revert "Merge branch '1.5.2-draft'" This reverts commit 633f5bb, reversing changes made to a9524d2. * Track buildspecs in repo like sklearn container (#248) Co-authored-by: Brent Millare <bmillare@amazon.com> * Pin flask dep itsdangerous (#251) Co-authored-by: Brent Millare <bmillare@amazon.com> * Add metrics for MultiClass (#250) * Add metrics for MultiClass * --amend Co-authored-by: Krittaphat Pugdeethosapol <krittp@amazon.com> * Add multiclass metrics (#252) * Add metrics for MultiClass * --amend * Allow new metrics for eval_metric Co-authored-by: Krittaphat Pugdeethosapol <krittp@amazon.com> * pin markupsafe jinja2 * Using ensemble flag for multi-model endpoint * Add accept encodings to alg_mode (#270) Co-authored-by: Brent Millare <bmillare@amazon.com> * Add missing integ test * added HP for `sampling_method` * added HP for `prob_buffer_row` remove after fixed in console * Fix JSON output format * removing duplicate files from data_path while creating symlink * not creating duplicate symlinks to resolve FileExistsError * not creating duplicate symlinks to resolve FileExistsError * not creating duplicate symlinks to resolve FileExistsError * not creating duplicate symlinks to resolve FileExistsError * not creating duplicate symlinks to resolve FileExistsError * not creating duplicate symlinks to resolve FileExistsError * not creating duplicate symlinks to resolve FileExistsError * not creating duplicate symlinks to resolve FileExistsError * not creating duplicate symlinks to resolve FileExistsError * not creating duplicate symlinks to resolve FileExistsError * Add warnings when validation files are suspected to be identical with training files (#273) * Add warnings when validation files are suspected to be identical with training files * Resolving comments Co-authored-by: Iaroslav Shcherbatyi <iaroslav.github@gmail.com> Co-authored-by: Iaroslav Shcherbatyi <siarosla@amazon.com> Co-authored-by: Mark Bunday <15115482+mabunday@users.noreply.github.com> Co-authored-by: Nikhil Raverkar <nraverka@amazon.com> Co-authored-by: haixiw <haixiw@amazon.com> Co-authored-by: Brent Millare <69818968+awsbmillare@users.noreply.github.com> Co-authored-by: Brent Millare <bmillare@amazon.com> Co-authored-by: Kritt <krittaphat.pug@gmail.com> Co-authored-by: Krittaphat Pugdeethosapol <krittp@amazon.com> Co-authored-by: Dewan Choudhury <cdewan@amazon.com> Co-authored-by: Haixin Wang <98612668+haixiw@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Sagemaker xgboost inference server already supports responses in the format of application/json and text/csv when using script_mode. In algorithm_mode, however, the code is hard coded to always return in the format text/csv. This change simply extends this response format support to algorithm_mode. This was simply missed from previous developments.
Also made serve.py match master:serve.py version in order to reduce divergence between branches.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.