Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Python version from 3.7 to 3.8 #288

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Conversation

mabunday
Copy link
Contributor

@mabunday mabunday commented May 31, 2022

Issue #, if available:

AWSALGO-5720

Description of changes:

Upgrade Python version from 3.7 to 3.8

Testing:

  • Beta integration tests
  • Gamma integration tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@@ -10,6 +10,7 @@ matplotlib==3.4.1
multi-model-server==1.1.2
numpy==1.21.0
pandas==1.2.4
protobuf==3.20.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same version of protobuf that we currently use, but I'm fixing it here because otherwise Python 3.8 tries to use a higher version that causes incompatibility.

@mabunday mabunday marked this pull request as ready for review June 1, 2022 04:29
Copy link
Contributor

@dewan-c dewan-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mabunday mabunday removed the request for review from NikhilRaverkar June 1, 2022 13:33
@mabunday mabunday merged commit fb7d0f8 into aws:master Jun 1, 2022
eugskim pushed a commit to eugskim/sagemaker-xgboost-container that referenced this pull request Jun 3, 2022
Co-authored-by: Mark Bunday <mabunday@amazon.com>
NikhilRaverkar pushed a commit that referenced this pull request Jun 7, 2022
* changed custom.metrics.py

* Added unit tests to custom_metrics.py

* Fixing build errors

* Small fix to docker file

* Fixed minor syntax errors

* Fixed some tests in test_train_utils.py

* Fixed assertion value, switched parameters of dtrain and preds

* Added more test to test_train_utils.py

* removed sort in test in test_train_utils.py

* Fixed slight syntax error

* small bug to test_train_utils.py

* Variable name fixed

* Fixed flake issues

* flake issues

* Reverted previous changes to dockerfile and changed numpy version

* Upgrade Python version from 3.7 to 3.8 (#288)

Co-authored-by: Mark Bunday <mabunday@amazon.com>

* Bump docker runtime version from 17 to 19 (#293)

* Bump docker runtime version from 17 to 19

* Remove explicit requests install from buildspec

Co-authored-by: Mark Bunday <mabunday@amazon.com>

* Changed numpy version in test train.py

Co-authored-by: Mark Bunday <15115482+mabunday@users.noreply.github.com>
Co-authored-by: Mark Bunday <mabunday@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants