Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Case2272044573 master merge (#285)" #290

Merged
merged 5 commits into from
Jun 2, 2022
Merged

Conversation

mabunday
Copy link
Contributor

@mabunday mabunday commented Jun 1, 2022

This reverts commit 81405a6.

Issue #, if available:

AWSALGO-5717

Description of changes:

Reverting changes due to failing integration tests.

Testing:

  • Beta integration tests
  • Gamma integration tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mabunday mabunday marked this pull request as ready for review June 2, 2022 16:42
Copy link
Contributor

@dewan-c dewan-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. I assume changes in #285 will be reworked by someone along with integ tests.

@mabunday mabunday merged commit 23ff1b1 into aws:1.3-1 Jun 2, 2022
NikhilRaverkar pushed a commit that referenced this pull request Jun 16, 2022
* Revert "Case2272044573 master merge (#285)"

This reverts commit 81405a6.

* Fix NVIDIA keyring error

* Bump docker runtime from 17 to 19

* Delete numpy-1.21.6 site packages

* Freeze protobuf to 3.20.1

Co-authored-by: Mark Bunday <mabunday@amazon.com>
NikhilRaverkar added a commit that referenced this pull request Jun 20, 2022
* added HP for `sampling_method`

* added HP for `prob_buffer_row` remove after fixed in console

* Case2272044573 master merge (#285)

* removing duplicate files from data_path while creating symlink

* not creating duplicate symlinks to resolve FileExistsError

* not creating duplicate symlinks to resolve FileExistsError

* not creating duplicate symlinks to resolve FileExistsError

* not creating duplicate symlinks to resolve FileExistsError

* not creating duplicate symlinks to resolve FileExistsError

* not creating duplicate symlinks to resolve FileExistsError

* not creating duplicate symlinks to resolve FileExistsError

* not creating duplicate symlinks to resolve FileExistsError

* not creating duplicate symlinks to resolve FileExistsError

* not creating duplicate symlinks to resolve FileExistsError

* Add warnings when validation files are suspected to be identical with training files (#273)

* Add warnings when validation files are suspected to be identical with training files

* Resolving comments

* Add warnings when validation files are suspected to be identical with training files (#273)

* Add warnings when validation files are suspected to be identical with training files

* Resolving comments

* remove the return statement in check redundancy function

* fix some format issues

* fixing Nvidia key error

* fixing Nvidia key error

* fixing Nvidia key error

* add debug logs

* add default value for validate path

* check if validation path is not set

* resolve comments on logging

Co-authored-by: Nikhil Raverkar <nraverka@amazon.com>
Co-authored-by: Haixin Wang <98612668+haixiw@users.noreply.github.com>
Co-authored-by: haixiw <haixiw@amazon.com>

* Revert "Case2272044573 master merge (#285)" (#290)

* Revert "Case2272044573 master merge (#285)"

This reverts commit 81405a6.

* Fix NVIDIA keyring error

* Bump docker runtime from 17 to 19

* Delete numpy-1.21.6 site packages

* Freeze protobuf to 3.20.1

Co-authored-by: Mark Bunday <mabunday@amazon.com>

* fixed errors Case2272044573

* fixed errors Case2272044573

* fixed errors Case2272044573

* fixed errors Case2272044573

* fixed errors Case2272044573

Co-authored-by: Nikhil Raverkar <nraverka@amazon.com>
Co-authored-by: Haixin Wang <98612668+haixiw@users.noreply.github.com>
Co-authored-by: haixiw <haixiw@amazon.com>
Co-authored-by: Mark Bunday <15115482+mabunday@users.noreply.github.com>
Co-authored-by: Mark Bunday <mabunday@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants