-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Case2272044573 master merge (#285)" #290
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 81405a6.
dewan-c
approved these changes
Jun 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving. I assume changes in #285 will be reworked by someone along with integ tests.
NikhilRaverkar
added a commit
that referenced
this pull request
Jun 20, 2022
* added HP for `sampling_method` * added HP for `prob_buffer_row` remove after fixed in console * Case2272044573 master merge (#285) * removing duplicate files from data_path while creating symlink * not creating duplicate symlinks to resolve FileExistsError * not creating duplicate symlinks to resolve FileExistsError * not creating duplicate symlinks to resolve FileExistsError * not creating duplicate symlinks to resolve FileExistsError * not creating duplicate symlinks to resolve FileExistsError * not creating duplicate symlinks to resolve FileExistsError * not creating duplicate symlinks to resolve FileExistsError * not creating duplicate symlinks to resolve FileExistsError * not creating duplicate symlinks to resolve FileExistsError * not creating duplicate symlinks to resolve FileExistsError * Add warnings when validation files are suspected to be identical with training files (#273) * Add warnings when validation files are suspected to be identical with training files * Resolving comments * Add warnings when validation files are suspected to be identical with training files (#273) * Add warnings when validation files are suspected to be identical with training files * Resolving comments * remove the return statement in check redundancy function * fix some format issues * fixing Nvidia key error * fixing Nvidia key error * fixing Nvidia key error * add debug logs * add default value for validate path * check if validation path is not set * resolve comments on logging Co-authored-by: Nikhil Raverkar <nraverka@amazon.com> Co-authored-by: Haixin Wang <98612668+haixiw@users.noreply.github.com> Co-authored-by: haixiw <haixiw@amazon.com> * Revert "Case2272044573 master merge (#285)" (#290) * Revert "Case2272044573 master merge (#285)" This reverts commit 81405a6. * Fix NVIDIA keyring error * Bump docker runtime from 17 to 19 * Delete numpy-1.21.6 site packages * Freeze protobuf to 3.20.1 Co-authored-by: Mark Bunday <mabunday@amazon.com> * fixed errors Case2272044573 * fixed errors Case2272044573 * fixed errors Case2272044573 * fixed errors Case2272044573 * fixed errors Case2272044573 Co-authored-by: Nikhil Raverkar <nraverka@amazon.com> Co-authored-by: Haixin Wang <98612668+haixiw@users.noreply.github.com> Co-authored-by: haixiw <haixiw@amazon.com> Co-authored-by: Mark Bunday <15115482+mabunday@users.noreply.github.com> Co-authored-by: Mark Bunday <mabunday@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 81405a6.
Issue #, if available:
AWSALGO-5717
Description of changes:
Reverting changes due to failing integration tests.
Testing:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.