Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default content type support for algorithm toolkit channel valdat… #35

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Add default content type support for algorithm toolkit channel valdat… #35

merged 1 commit into from
Oct 1, 2019

Conversation

ericangelokim
Copy link
Contributor

…ion.

Description of changes:

Add default content type support for channel validation.
Add "text/libsvm" as default content type for XGBoost.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

aws-patlin
aws-patlin approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@aws-patlin aws-patlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, since you didn't mention testing in the PR description, did you run tox and have all commands succeed?

@ericangelokim
Copy link
Contributor Author

Note: Ran python3 -m tox to make sure all tests and flake completed.

@ericangelokim ericangelokim merged commit 094a87b into master Oct 1, 2019
@mabunday mabunday deleted the default_content_type branch August 5, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aws-patlin aws-patlin aws-patlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ericangelokim @aws-patlin