Remove additional parameters from content_type #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes following changes: 1. get_content_type parsed the MIME type to remove optional parameters from the CSV type. We apply that parsing rule for all content types allowing optional key-value parameters after the primary type string. 2. Inference handler has been updated to perform case-insensitive comparison and allow optional parameters.
aws-patlin
reviewed
Nov 14, 2019
| @@ -24,6 +24,8 @@ | |||
| from sagemaker_xgboost_container import encoder as xgb_encoder | |||
| from sagemaker_xgboost_container.algorithm_mode.inference_errors import NoContentInferenceError, \ | |||
| UnsupportedMediaTypeInferenceError, ModelLoadInferenceError, BadRequestInferenceError | |||
| from sagemaker_xgboost_container.data_utils import get_content_type | |||
| from sagemaker_xgboost_container.data_utils import CSV, LIBSVM, PARQUET, RECORDIO_PROTOBUF | |||
There was a problem hiding this comment.
We don't use PARQUET during inference, and flake8 complains about this.
aws-patlin
force-pushed
the
bugfix/content_type_case
branch
from
67fcb8e
to
80c2dca
Compare
|
Unit tests added, tested with tox and passing. |
ericangelokim
approved these changes
Nov 14, 2019
| try: | ||
| if accept == content_types.CSV or accept == 'csv': | ||
| if accept_type == content_types.CSV or accept_type == 'csv': |
There was a problem hiding this comment.
Why don't we parse accept_type similar to the way content_type is now parsed?
There was a problem hiding this comment.
Primarily because of json not being part of our data_utils types.
|
Found a slight bug. Confirming the fix via container tests. |
aws-patlin
force-pushed
the
bugfix/content_type_case
branch
from
80c2dca
to
9cd3d73
Compare
aws-patlin
approved these changes
Nov 14, 2019
Added exception handling for calling get_content_type.
aws-patlin
force-pushed
the
bugfix/content_type_case
branch
from
9cd3d73
to
15d6d27
Compare
ericangelokim
pushed a commit
that referenced
this pull request
Nov 22, 2019
This was referenced Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This commit includes following changes:
from the CSV type. We apply that parsing rule for all content types
allowing optional key-value parameters after the primary type string.
comparison and allow optional parameters.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.