chore: add missing partition to edge config support (#3605)

aws · May 29, 2024 · 308d9ce · 308d9ce
1 parent c8e7cf8
commit 308d9ce
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 11 deletions.
diff --git a/samtranslator/region_configuration.py b/samtranslator/region_configuration.py
@@ -17,8 +17,10 @@ def is_apigw_edge_configuration_supported(cls) -> bool:
 
         :return: True, if API Gateway does not support Edge configuration
         """
-
-        return ArnGenerator.get_partition_name() not in ["aws-us-gov", "aws-iso", "aws-iso-b", "aws-cn", "aws-iso-e"]
+        partition = ArnGenerator.get_partition_name()
+        if partition.startswith("aws-iso") or partition in ["aws-us-gov", "aws-cn"]:
+            return False
+        return True
 
     @classmethod
     def is_service_supported(cls, service, region=None):  # type: ignore[no-untyped-def]

diff --git a/tests/unit/test_region_configuration.py b/tests/unit/test_region_configuration.py
@@ -20,15 +20,7 @@ def test_when_apigw_edge_configuration_supported(self, partition):
 
             self.assertTrue(RegionConfiguration.is_apigw_edge_configuration_supported())
 
-    @parameterized.expand(
-        [
-            ["aws-cn"],
-            ["aws-us-gov"],
-            ["aws-iso"],
-            ["aws-iso-b"],
-            ["aws-iso-e"],
-        ]
-    )
+    @parameterized.expand([["aws-cn"], ["aws-us-gov"], ["aws-iso"], ["aws-iso-b"], ["aws-iso-e"], ["aws-iso-f"]])
     def test_when_apigw_edge_configuration_is_not_supported(self, partition):
         with patch(
             "samtranslator.translator.arn_generator.ArnGenerator.get_partition_name"