Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Attach connectors to source #2772

Merged
merged 36 commits into from Jan 24, 2023
Merged

feat: Attach connectors to source #2772

merged 36 commits into from Jan 24, 2023

Conversation

aaythapa
Copy link
Contributor

@aaythapa aaythapa commented Jan 6, 2023

Issue #, if available

Description of changes

We want users to be able to attach their connector definition to the source property.

Description of how you validated changes

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

aahung
aahung reviewed Jan 6, 2023
View reviewed changes
samtranslator/translator/translator.py Outdated Show resolved Hide resolved
samtranslator/translator/translator.py Outdated Show resolved Hide resolved
samtranslator/translator/translator.py Outdated Show resolved Hide resolved
samtranslator/translator/translator.py Outdated Show resolved Hide resolved
samtranslator/translator/translator.py Outdated Show resolved Hide resolved
samtranslator/translator/translator.py Outdated Show resolved Hide resolved
samtranslator/translator/translator.py Outdated Show resolved Hide resolved
samtranslator/translator/translator.py Outdated Show resolved Hide resolved
samtranslator/translator/translator.py Outdated Show resolved Hide resolved
@hoffa hoffa mentioned this pull request Jan 18, 2023
Merged
5 tasks
@aaythapa aaythapa marked this pull request as ready for review January 18, 2023 22:11
@aaythapa aaythapa requested a review from a team as a code owner January 18, 2023 22:11
@aaythapa aaythapa requested review from aahung and hoffa January 18, 2023 22:12
hoffa
hoffa reviewed Jan 19, 2023
View reviewed changes
samtranslator/translator/translator.py Outdated Show resolved Hide resolved
samtranslator/schema/aws_serverless_api.py Outdated Show resolved Hide resolved
samtranslator/translator/translator.py Outdated Show resolved Hide resolved
hoffa
hoffa approved these changes Jan 24, 2023
View reviewed changes
samtranslator/translator/translator.py Outdated Show resolved Hide resolved
samtranslator/translator/translator.py Outdated Show resolved Hide resolved
samtranslator/translator/verify_logical_id.py Outdated Show resolved Hide resolved
samtranslator/translator/translator.py Outdated Show resolved Hide resolved
samtranslator/schema/aws_serverless_function.py Show resolved Hide resolved
@hoffa hoffa changed the title Attach connectors to source feat: Attach connectors to source Jan 24, 2023
@hoffa hoffa self-requested a review January 24, 2023 01:03
@aaythapa aaythapa removed the request for review from aahung January 24, 2023 01:26
@aaythapa aaythapa merged commit 96691c1 into aws:develop Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoffa hoffa hoffa approved these changes

@aahung aahung aahung left review comments

@GavinZZ GavinZZ GavinZZ left review comments

@awood45 awood45 awood45 approved these changes

@xazhao xazhao xazhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@aaythapa @xazhao @hoffa @awood45 @aahung @GavinZZ @aws-sam-cli-bot