Skip to content

Conversation

hoffa
Copy link
Contributor

@hoffa hoffa commented Jan 16, 2023

Issue #, if available

Description of changes

Adds new unified.schema.json that includes both SAM and CloudFormation resources.

We need control over the CloudFormation schema, so that e.g. we can allow additionalProperties such as #2772 on them.

Other notes:

  • Eventually will rename schema.json to sam.schema.json, and unified.schema.json to schema.json so that existing users of the schema will automatically get the improvements.
  • The CloudFormation schema doesn't support intrinsic functions (see SAM/CFN json schema: handle of intrinsic functions aws-toolkit-vscode#2596).
  • We should add some automation to automatically update the schema.

Description of how you validated changes

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hoffa hoffa changed the title feat: extend schema with CloudFormation schema feat: unified SAM + CloudFormation schema Jan 18, 2023
@hoffa hoffa changed the title feat: unified SAM + CloudFormation schema feat: unified SAM/CloudFormation schema Jan 18, 2023
@hoffa hoffa marked this pull request as ready for review January 18, 2023 22:24
@hoffa hoffa requested a review from a team as a code owner January 18, 2023 22:24
@hoffa hoffa requested a review from awood45 January 18, 2023 23:32
@hoffa hoffa merged commit a4b4b9a into aws:develop Jan 18, 2023
@hoffa hoffa deleted the extend-schema branch January 18, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants