-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to define minimumCompressionSize and a few other API Gateway settings in template #519
Comments
Some follow up notes: I was able to add minimumCompressionSize by including it as such in my swagger DefinitionBody:
The other two fields,
and
seem to default to the values I have listed, however I would still prefer if all of these things were configurable without a custom resource. |
Add minimum compression size is logged in issue #419 |
Main areas to modify are: Then add tests and docs 👍 |
I would like to contribute on this issue, but couldn't find these parameters on the cloudformation docs. Can you confirm this is already supported ? https://docs.aws.amazon.com/apigateway/api-reference/resource/stage/ Thanks |
I see that MinimumCompressionSize support was released with this PR #786 I don't see the other two supported in CFN, you are right @eduardovra. We will reach out to the right teams with this information, thank you. |
Still looks like
Closing. Given we don't have a current path on the outstanding ones, I am going to close this. Feel free to re-open once there is a path for support. |
I searched the issues and don't see a duplicate for any of the following keys that seem to be unsupported by
AWS::Serverless::Api
Failing body is below with explanations. The seemingly unsupported keys are:
MinimumCompressionSize
and
MethodSettings
:RequireAuthorizationForCacheControl
UnauthorizedCacheControlHeaderStrategy
As the CLI can create an API with these, I'd expect them to work with the serverless transform. I see the issue #248 has a lot of work for additional fields (some of which I'm even using 😄) but enabling these manually would essentially be a blocker for us at bustle trying to use SAM. Are there any workarounds or do these belong somewhere other than
Properties
, etc?Note: the following will deploy with the comments removed, and will fail if any of these fields are added one off.
Thanks in advance for any insight!
The text was updated successfully, but these errors were encountered: