Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MinimumCompressionSize #786

Merged
merged 4 commits into from
Feb 1, 2019

Conversation

rm-hull
Copy link
Contributor

@rm-hull rm-hull commented Jan 26, 2019

Issue #, if available:

Fixes #419 (and partially #519)

Description of changes:

Adds support to tunnel through the minimum compression size parameter

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rm-hull rm-hull force-pushed the feature/minimum-compression-size branch from 2edcb60 to 7ce415a Compare January 26, 2019 19:15
@codecov-io
Copy link

codecov-io commented Jan 26, 2019

Codecov Report

Merging #786 into develop will decrease coverage by 0.48%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #786      +/-   ##
===========================================
- Coverage    94.71%   94.23%   -0.49%     
===========================================
  Files           67       67              
  Lines         2950     2687     -263     
  Branches       578      478     -100     
===========================================
- Hits          2794     2532     -262     
- Misses          78       80       +2     
+ Partials        78       75       -3
Impacted Files Coverage Δ
samtranslator/model/apigateway.py 96.32% <ø> (ø) ⬆️
samtranslator/plugins/globals/globals.py 100% <ø> (ø) ⬆️
samtranslator/model/sam_resources.py 95.72% <ø> (-1.25%) ⬇️
samtranslator/model/s3_utils/uri_parser.py 71.42% <0%> (ø) ⬆️
samtranslator/model/api/api_generator.py 96.13% <100%> (-0.34%) ⬇️
samtranslator/translator/translator.py 99.02% <100%> (ø) ⬆️
samtranslator/model/eventsources/push.py 86.06% <0%> (-4.24%) ⬇️
samtranslator/model/eventsources/cloudwatchlogs.py 100% <0%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cf48bd...c25cec1. Read the comment docs.

@keetonian keetonian changed the base branch from master to develop January 29, 2019 06:27
Copy link
Contributor

@keetonian keetonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do you think that this property would be useful in the Globals section?

@brettstack brettstack merged commit ce8d889 into aws:develop Feb 1, 2019
@alexdilley
Copy link

How do you point the SAM CLI to build against the latest Serverless Application Model release (v1.10.0), and pick this change up?

@jlhood
Copy link
Contributor

jlhood commented Mar 7, 2019

@alexdilley SAM CLI has already made the change to update their SAM translator dependency in aws/aws-sam-cli#1043. It will go out with their next release, which should be soon. Then you can update to the latest SAM CLI version.

If you need it even faster, you could follow the SAM CLI Development Guide which walks you through installing a samdev command containing the latest development changes.

@rm-hull rm-hull deleted the feature/minimum-compression-size branch January 8, 2020 23:37
@rm-hull rm-hull restored the feature/minimum-compression-size branch January 8, 2020 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants