-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MinimumCompressionSize #786
Add support for MinimumCompressionSize #786
Conversation
2edcb60
to
7ce415a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #786 +/- ##
===========================================
- Coverage 94.71% 94.23% -0.49%
===========================================
Files 67 67
Lines 2950 2687 -263
Branches 578 478 -100
===========================================
- Hits 2794 2532 -262
- Misses 78 80 +2
+ Partials 78 75 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Do you think that this property would be useful in the Globals section?
It already supports the globals section - see https://github.com/awslabs/serverless-application-model/pull/786/files#diff-3f7318c617864e2cb6821b32cd63ef77R3 (the test template) and https://github.com/awslabs/serverless-application-model/pull/786/files#diff-17c169d57f967c224092f6986791b0c1R172 (the converted document). Notice how the global is set to 1024, but the explicitly set value is 256 (https://github.com/awslabs/serverless-application-model/pull/786/files#diff-3f7318c617864e2cb6821b32cd63ef77R24 and https://github.com/awslabs/serverless-application-model/pull/786/files#diff-17c169d57f967c224092f6986791b0c1R105 respectively) |
How do you point the SAM CLI to build against the latest Serverless Application Model release (v1.10.0), and pick this change up? |
@alexdilley SAM CLI has already made the change to update their SAM translator dependency in aws/aws-sam-cli#1043. It will go out with their next release, which should be soon. Then you can update to the latest SAM CLI version. If you need it even faster, you could follow the SAM CLI Development Guide which walks you through installing a |
Issue #, if available:
Fixes #419 (and partially #519)
Description of changes:
Adds support to tunnel through the minimum compression size parameter
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.