Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VpcConfig invalid when referencing other resources #57

Closed
jkahn117 opened this issue Jan 9, 2017 · 6 comments
Closed

VpcConfig invalid when referencing other resources #57

jkahn117 opened this issue Jan 9, 2017 · 6 comments

Comments

@jkahn117
Copy link

jkahn117 commented Jan 9, 2017

The following returns the error message Resource with id [SampleFunction] is invalid. Type of property 'VpcConfig' is invalid. though appears to be valid.

VpcConfig:
  SecurityGroupIds:
    - !Ref FunctionSecurityGroup
  SubnetIds:
    - !ImportValue "aroundme-private-subnet"

When I modify the block to reference the actual values (as follows), template works as expected, thus this seems to be a transform issue.

VpcConfig:
  SecurityGroupIds:
    - "sg-ABC123"
  SubnetIds:
    - "subnet-ABC123"
@sanathkr
Copy link
Contributor

Known bug. Related to #22.

We are working on resolving this now. We will update this thread once its resolved

@joekiller
Copy link

joekiller commented Feb 16, 2017 via email

@dinvlad
Copy link

dinvlad commented Feb 17, 2017

I'm doing everything through CodePipeline now and strangely, it doesn't appear to have this problem.

EDIT: haven't tested with ImportValue though, it may be the only thing still not supported.

EDIT2: Seems like deletion of ENI still doesn't work if there are referenced resources (even when references are resolved correctly), see #64

@sanathkr
Copy link
Contributor

@dinvlad that's because we just recently deployed the fix :-) Intrinsic functions should just work, except for ImportValue specifically in a few places - https://github.com/awslabs/serverless-application-model/blob/master/HOWTO.md#using-intrinsic-functions

@dinvlad
Copy link

dinvlad commented Feb 17, 2017

Yep, working correctly now!

@jkahn117
Copy link
Author

Confirmed, now working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants