Remove cfn lint #1034
Merged
Remove cfn lint #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1034 +/- ##
========================================
Coverage 94.82% 94.82%
========================================
Files 69 69
Lines 3244 3244
Branches 632 632
========================================
Hits 3076 3076
Misses 87 87
Partials 81 81Continue to review full report at Codecov.
|
jlhood
reviewed
Jul 23, 2019
There was a problem hiding this comment.
Are we going to open an issue to find a way to add cfn-lint back? It's very helpful to lint output templates to make sure they're correct... We could install it separately as part of the Travis run and then just run it against all output templates. That way it's not part of our dependency closure. Is that a difficult change? Could we just do that as part of this PR instead of only removing it?
jlhood
approved these changes
Jul 25, 2019
praneetap
approved these changes
Jul 26, 2019
yan12125
pushed a commit
to macports/macports-ports
that referenced
this pull request
Oct 3, 2019
cfn-lint is no longer a test dependency since [1], and the test suite is green now. [1] aws/serverless-application-model#1034
svenstaro
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Jul 22, 2020
python-cfn-lint is no longer needed [1]. It might be re-added in the future, though [2]. [1] aws/serverless-application-model#1034 [2] aws/serverless-application-model#1042 git-svn-id: file:///srv/repos/svn-community/svn@505539 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1008
Description of changes:
Removes cfn-lint test dependency
Description of how you validated changes:
Tests run and pass
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.