Binary media types bug fix #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1043 +/- ##
===========================================
+ Coverage 94.82% 94.82% +<.01%
===========================================
Files 69 69
Lines 3244 3248 +4
Branches 632 632
===========================================
+ Hits 3076 3080 +4
Misses 87 87
Partials 81 81
Continue to review full report at Codecov.
|
keetonian
commented
Jul 25, 2019
| @@ -257,7 +258,8 @@ def add_cors(self, path, allowed_origins, allowed_headers=None, allowed_methods= | |||
| allow_credentials) | |||
|
|
|||
| def add_binary_media_types(self, binary_media_types): | |||
| self._doc[self._X_APIGW_BINARY_MEDIA_TYPES] = binary_media_types | |||
| bmt = json.loads(json.dumps(binary_media_types).replace('~1', '/')) | |||
There was a problem hiding this comment.
Dump it into json so all nested lists and dictionaries are expressed as a string, replace the ~1 with /, and then load back into data form.
jlhood
reviewed
Jul 25, 2019
keetonian
force-pushed
the
binary-media-types
branch
from
c6cd846
to
9a67613
Compare
jlhood
approved these changes
Jul 25, 2019
praneetap
reviewed
Jul 26, 2019
praneetap
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1036
Description of changes:
Converts
~1to/, as is expected in the swagger for binary media types.The CloudFormation property expects
~1. Docs: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apigateway-restapi.html#cfn-apigateway-restapi-binarymediatypesThe Swagger property expects
/. Docs: https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-swagger-extensions-binary-media-types.htmlDescription of how you validated changes:
Tests updated and pass.
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.