New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sam support to add resource policies to api properties #1045
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1045 +/- ##
==========================================
- Coverage 94.91% 94.8% -0.12%
==========================================
Files 69 69
Lines 3248 3274 +26
Branches 631 639 +8
==========================================
+ Hits 3083 3104 +21
- Misses 87 89 +2
- Partials 78 81 +3
Continue to review full report at Codecov.
|
55c317a
to
ccb4ee3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one minor comment about a comment.
tests/translator/input/api_with_resource_policy_global_intrinsic.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thanks for iterating on this!
Issue #, if available:
#514
Description of changes:
Added support for resource policies on api definition in SAM.
Description of how you validated changes:
Transformed this template locally and deployed it on CFN successfully. I could invoke the API successfully.
Checklist:
make pr
passesexamples/2016-10-31
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.