Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch fix for Release v1.13.2 #1061

Merged
merged 3 commits into from
Aug 1, 2019
Merged

patch fix for Release v1.13.2 #1061

merged 3 commits into from
Aug 1, 2019

Conversation

praneetap
Copy link
Contributor

@praneetap praneetap commented Aug 1, 2019

Issue #, if available:
#191
Description of changes:
creating a release branch for v1.13.2. This has the fix for the issue seen in v1.13.0 where adding OpenApiVersion flag to the template did not cause the APIGW APIs to get redeployed in some cases. More in this comment

Description of how you validated changes:
make pr
Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Aug 1, 2019

Codecov Report

Merging #1061 into release/v1.13.2 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v1.13.2    #1061      +/-   ##
===================================================
+ Coverage            94.86%   94.87%   +<.01%     
===================================================
  Files                   69       69              
  Lines                 3156     3161       +5     
  Branches               602      603       +1     
===================================================
+ Hits                  2994     2999       +5     
  Misses                  84       84              
  Partials                78       78
Impacted Files Coverage Δ
samtranslator/model/api/api_generator.py 95.33% <100%> (ø) ⬆️
samtranslator/model/apigateway.py 97.79% <100%> (+0.06%) ⬆️
samtranslator/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bd5430...0758504. Read the comment docs.

samtranslator/model/apigateway.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use git cherry-pick from commits on latest develop branch to pull in the changes.

Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jlhood jlhood merged commit 1dd787f into aws:release/v1.13.2 Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants