fix: Raise exception if provided Auth.Authorizers.Identity isn't a dict #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2273 +/- ##
===========================================
+ Coverage 93.58% 94.39% +0.81%
===========================================
Files 90 97 +7
Lines 6124 7086 +962
Branches 1260 1434 +174
===========================================
+ Hits 5731 6689 +958
+ Misses 183 181 -2
- Partials 210 216 +6
Continue to review full report at Codecov.
|
mndeveci
reviewed
Dec 20, 2021
samtranslator/model/apigateway.py
Outdated
Comment on lines
398
to
406
| try: | ||
| if not self.identity or not self.identity.get("Header"): | ||
| return "Authorization" | ||
| except AttributeError: | ||
| raise InvalidResourceException( | ||
| self.api_logical_id, | ||
| "Auth.Authorizers.<Authorizer>.Identity must be a dict (LambdaTokenAuthorizationIdentity " | ||
| "or LambdaRequestAuthorizationIdentity).", | ||
| ) |
There was a problem hiding this comment.
Instead of try/except block, shouldn't we check if the property is an expected type (dict in this case)?
hawflau
approved these changes
Jan 11, 2022
torresxb1
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Description of how you validated changes:
Checklist:
make prpassesExamples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam initthrough https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.