Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Py2 dependencies and update to use native unittest.mock #2299

Merged
merged 1 commit into from Jan 20, 2022

Conversation

hawflau
Copy link
Contributor

@hawflau hawflau commented Jan 19, 2022

Issue #, if available:

Description of changes:

  • Remove all Py2 dependencies
  • Update to use native unittest.mock instead of external mock library

Description of how you validated changes:

Checklist:

  • Add/update tests using:
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

boto3~=1.5
enum34~=1.1; python_version<"3.4"
jsonschema~=3.2
six~=1.15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need six if we are on py2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only use string_types and assertCountEqual from six. Let me check if we can safely remove them and replace with something else. If yet, I'll submit another PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do another PR to keep things scoped.

@hawflau hawflau merged commit a308593 into aws:develop Jan 20, 2022
@hawflau hawflau deleted the py2-cleanup branch January 20, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants