Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation for API property Model #2340

Merged
merged 1 commit into from Mar 22, 2022

Conversation

jonife
Copy link
Contributor

@jonife jonife commented Mar 8, 2022

Issue #, if available:

Description of changes:
Added validation to Api property Model to ensure that its either of type dict or an intrinsic function.

Description of how you validated changes:
if a customer provides in a SAM a value API property Model and its neither a type dict nor an intrinsic function. An error is raised notifying the customer of the invalid type.

Checklist:

  • Add/update unit tests using:
  • Add/update integration tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mildaniel mildaniel merged commit 02921bc into aws:develop Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants