Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add retries on flaky integration test #2343

Merged
merged 2 commits into from
Mar 9, 2022
Merged

test: Add retries on flaky integration test #2343

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ede974
Add retries on flaky integration test
mildaniel Mar 8, 2022
61779c2
Fix cors origins header name
mildaniel Mar 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions integration/combination/test_api_with_gateway_responses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from unittest.case import skipIf

from integration.helpers.base_test import BaseTest
from integration.helpers.deployer.utils.retry import retry
from integration.helpers.resource import current_region_does_not_support
from integration.config.service_names import GATEWAY_RESPONSES

Expand Down Expand Up @@ -30,8 +31,12 @@ def test_gateway_responses(self):
self.assertEqual(gateway_response.get("statusCode"), None, "gatewayResponse: status code must be none")

base_url = stack_outputs["ApiUrl"]
response = self.verify_get_request_response(base_url + "iam", 403)
access_control_allow_origin = response.headers["Access-Control-Allow-Origin"]
self._verify_request_response_and_cors(base_url + "iam", 403)
mildaniel marked this conversation as resolved.
Show resolved Hide resolved

@retry(AssertionError, exc_raise=AssertionError, exc_raise_msg="Unable to verify GatewayResponse request.")
def _verify_request_response_and_cors(self, url, expected_response):
response = self.verify_get_request_response(url, expected_response)
access_control_allow_origin = response.headers.get("Access-Control-Allow-Origin", "")
self.assertEqual(access_control_allow_origin, "*", "Access-Control-Allow-Origin must be '*'")


Expand Down