New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Furl AutopublishAlias bug fix #2378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @jonife .
Can we check the following failure?
FAILED tests/model/api/test_http_api_generator.py::TestHttpApiGenerator::test_enabling_auth_iam_does_not_clobber_conflicting_custom_authorizer - samtranslator.model.exceptions.InvalidResourceException: ('HttpApiId', "Specify either 'Defi...
And also, will this require any documentation change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only question is are there integration tests we need to update with these? We recently adding python integration tests in the repo and want to make sure we have the correct coverage.
can't seem to think of any one of the top of my head, i think the integration test covers everything |
Should we test calling the Function URL to confirm if the Lambda Function Alias is invoked without any error? From what I understand, the integration test for FURL does not make any call to the created FURL. |
note: we will submit another PR to address the integration tests |
Issue #, if available:
#2373
Description of changes:
Grant public access to function alias
Checklist:
make pr
passesExamples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam init
through https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.