Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass the condition attribute to the generated function url resources for the conditional functions #2388

Merged

Conversation

moelasmar
Copy link
Contributor

Issue #, if available:
#2385

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2022

Codecov Report

Merging #2388 (de140b0) into develop (e7a1496) will increase coverage by 0.81%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2388      +/-   ##
===========================================
+ Coverage    93.58%   94.39%   +0.81%     
===========================================
  Files           90       98       +8     
  Lines         6124     7213    +1089     
  Branches      1260     1490     +230     
===========================================
+ Hits          5731     6809    +1078     
- Misses         183      196      +13     
+ Partials       210      208       -2     
Impacted Files Coverage Δ
samtranslator/region_configuration.py 77.77% <0.00%> (-22.23%) ⬇️
samtranslator/validator/validator.py 91.80% <0.00%> (-3.85%) ⬇️
samtranslator/model/exceptions.py 97.67% <0.00%> (-2.33%) ⬇️
samtranslator/open_api/open_api.py 90.03% <0.00%> (-1.94%) ⬇️
samtranslator/model/s3_utils/uri_parser.py 68.42% <0.00%> (-0.81%) ⬇️
samtranslator/yaml_helper.py 89.47% <0.00%> (-0.53%) ⬇️
samtranslator/translator/logical_id_generator.py 90.62% <0.00%> (-0.29%) ⬇️
samtranslator/model/api/api_generator.py 94.08% <0.00%> (-0.28%) ⬇️
samtranslator/model/apigateway.py 96.98% <0.00%> (-0.18%) ⬇️
samtranslator/intrinsics/resource_refs.py 95.83% <0.00%> (-0.17%) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9306a03...de140b0. Read the comment docs.

@moelasmar moelasmar changed the title (fix) pass the condition attribute to the generated function url resources for the conditional functions fix: pass the condition attribute to the generated function url resources for the conditional functions Apr 25, 2022
@jfuss jfuss merged commit 2af8d47 into aws:develop May 3, 2022
@moelasmar moelasmar deleted the develop_conditional_function_url_config branch May 3, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants