Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FURL integ test to test invoke #2401

Merged
merged 2 commits into from May 23, 2022

Conversation

hawflau
Copy link
Contributor

@hawflau hawflau commented May 19, 2022

Issue #, if available:
N/A

Description of changes:
Update FURL integration test to test invoke the created Lambda Function

Description of how you validated changes:
Running the updated tests from my laptop

Checklist:

  • Add/update unit tests using:
  • Add/update integration tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

boto3~=1.17
boto3>=1.23,<2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we needed boto version bump here? In order to support a new parameter to lambda_client.invoke?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a miss from the FURL PR actually, as the FURL integration test is using lambda_client.get_function_url_config, which is only available in boto3 1.22.15 or above

@jfuss jfuss merged commit 6f73f4a into aws:develop May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants