Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Foss] Sync public: Update custom domain tests resource #2435

Merged
merged 1 commit into from Jun 30, 2022

Conversation

mingkun2020
Copy link
Contributor

Description of changes:
Update some resources(template, expected json file) for custom domain tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2022

Codecov Report

Merging #2435 (0bf852d) into develop (e7a1496) will increase coverage by 0.85%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2435      +/-   ##
===========================================
+ Coverage    93.58%   94.43%   +0.85%     
===========================================
  Files           90       98       +8     
  Lines         6124     7266    +1142     
  Branches      1260     1511     +251     
===========================================
+ Hits          5731     6862    +1131     
- Misses         183      195      +12     
+ Partials       210      209       -1     
Impacted Files Coverage Δ
samtranslator/region_configuration.py 77.77% <0.00%> (-22.23%) ⬇️
samtranslator/model/codedeploy.py 90.90% <0.00%> (-9.10%) ⬇️
samtranslator/validator/validator.py 91.80% <0.00%> (-3.85%) ⬇️
samtranslator/model/exceptions.py 97.67% <0.00%> (-2.33%) ⬇️
samtranslator/open_api/open_api.py 90.16% <0.00%> (-1.81%) ⬇️
samtranslator/model/s3_utils/uri_parser.py 68.42% <0.00%> (-0.81%) ⬇️
samtranslator/yaml_helper.py 89.47% <0.00%> (-0.53%) ⬇️
samtranslator/translator/logical_id_generator.py 90.62% <0.00%> (-0.29%) ⬇️
samtranslator/model/api/api_generator.py 94.08% <0.00%> (-0.28%) ⬇️
samtranslator/model/apigateway.py 96.98% <0.00%> (-0.18%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27e98f0...0bf852d. Read the comment docs.

@mingkun2020 mingkun2020 merged commit e62dcfc into aws:develop Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants