Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add public interface command check #2872

Merged
merged 3 commits into from
Feb 8, 2023

Conversation

aahung
Copy link
Contributor

@aahung aahung commented Feb 8, 2023

Issue #, if available

Description of changes

Why print markdown? So we can forward the output and present it in PR comment.

Description of how you validated changes

❯❯❯ bin/public_interface.py check out.json new.json
Compatibility breaking changes detected!!!

# Compatibility breaking changes:
** These changes are considered breaking changes and may break packages consuming
aws-sam-translator on pypi.
Please consider revisiting these changes to make sure they are intentional:**

## Deleted module level variables
- samtranslator.model.sam_resources.IMAGE
- samtranslator.model.sam_resources.X86_64
- samtranslator.model.sam_resources.ZIP
- samtranslator.model.stepfunctions.events.CONDITION
- samtranslator.model.stepfunctions.events.SFN_EVETSOURCE_METRIC_PREFIX
- samtranslator.plugins.api.implicit_api_plugin.MIN_NUM_CONDITIONS_TO_COMBINE
- samtranslator.plugins.application.serverless_app_plugin.BOTO3_CONNECT_TIMEOUT
- samtranslator.plugins.application.serverless_app_plugin.PLUGIN_METRICS_PREFIX
- samtranslator.policy_template_processor.template.POLICY_PARAMETER_DISAMBIGUATE_PREFIX
- samtranslator.policy_templates_data.POLICY_TEMPLATES_FILE
- samtranslator.policy_templates_data.SCHEMA_FILE
- samtranslator.translator.translator.TYPE_CHECKING
- samtranslator.translator.verify_logical_id.do_not_verify
- samtranslator.utils.constants.BOTO3_CONNECT_TIMEOUT
- samtranslator.utils.py27hash_fix.MINSIZE

## Deleted routines
- samtranslator.feature_toggle.dialup.SimpleAccountPercentileDialup.is_enabled
- samtranslator.feature_toggle.dialup.ToggleDialup.is_enabled
- samtranslator.feature_toggle.feature_toggle.FeatureToggle.is_enabled

## Deleted routines
- samtranslator.validator.validator.is_object: `(checker, instance)` -> `(checker, instance, instance1)`

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aahung aahung force-pushed the add-public-interface-command-check branch 3 times, most recently from d2cef87 to 59b6738 Compare February 8, 2023 21:55
@aahung aahung changed the title Add public interface command check ci: Add public interface command check Feb 8, 2023
@aahung aahung force-pushed the add-public-interface-command-check branch 2 times, most recently from 7f37e6e to 590cda5 Compare February 8, 2023 22:02
@aahung aahung marked this pull request as ready for review February 8, 2023 22:02
@aahung aahung requested a review from a team as a code owner February 8, 2023 22:02
@aahung aahung force-pushed the add-public-interface-command-check branch from 590cda5 to 513a030 Compare February 8, 2023 22:04
bin/public_interface.py Outdated Show resolved Hide resolved
bin/public_interface.py Outdated Show resolved Hide resolved
@aahung aahung force-pushed the add-public-interface-command-check branch from 513a030 to 091e72e Compare February 8, 2023 22:10
@aahung aahung enabled auto-merge (squash) February 8, 2023 22:10
@aahung aahung merged commit afc68ac into aws:develop Feb 8, 2023
@aahung aahung deleted the add-public-interface-command-check branch February 8, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants