Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use pull_request instead of pull_request_target in compatibility action #2883

Merged
merged 11 commits into from
Feb 9, 2023

Conversation

aahung
Copy link
Contributor

@aahung aahung commented Feb 9, 2023

…action

Issue #, if available

Description of changes

Description of how you validated changes

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Compatibility breaking changes:

These changes are considered breaking changes and may break packages consuming
the PyPI package aws-sam-translator.
Please consider revisiting these changes to make sure they are intentional:

Deleted routines

  • samtranslator.open_api.base_editor.BaseEditor.make_path_conditional
  • samtranslator.open_api.open_api.OpenApiEditor.make_path_conditional
  • samtranslator.swagger.swagger.SwaggerEditor.make_path_conditional

@aahung aahung changed the title ci: Use pull_request instead of pull_request_target in compatibility … ci: Use pull_request instead of pull_request_target in compatibility action Feb 9, 2023
@aahung aahung marked this pull request as ready for review February 9, 2023 19:24
@aahung aahung requested a review from a team as a code owner February 9, 2023 19:24
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Compatibility breaking changes:

These changes are considered breaking changes and may break packages consuming
the PyPI package aws-sam-translator.
Please consider revisiting these changes to make sure they are intentional:

Deleted routines

  • samtranslator.open_api.base_editor.BaseEditor.make_path_conditional
  • samtranslator.open_api.open_api.OpenApiEditor.make_path_conditional
  • samtranslator.swagger.swagger.SwaggerEditor.make_path_conditional

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Compatibility breaking changes:

These changes are considered breaking changes and may break packages consuming
the PyPI package aws-sam-translator.
Please consider revisiting these changes to make sure they are intentional:

Deleted routines

  • samtranslator.open_api.base_editor.BaseEditor.make_path_conditional
  • samtranslator.open_api.open_api.OpenApiEditor.make_path_conditional
  • samtranslator.swagger.swagger.SwaggerEditor.make_path_conditional

@aahung aahung enabled auto-merge (squash) February 9, 2023 19:43
@aahung aahung merged commit 6064249 into aws:develop Feb 9, 2023
@aahung aahung deleted the update-interface-gh-action branch February 9, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants