-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Documentation page for CloudFormation Compatibility #290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for doing this. This is an important step forward. I have some minor corrections
|
||
CloudFormation Intrinsic Funtions | ||
------------------- | ||
Currently, we do not support all Intrinsic Functions for all Property Values. Please see below tables for a details on which Intrinsic Functions can be used on a given field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you mention that intrinsics support is partial in AWS::Serverless::* resources, but fully available in other CloudFormation resources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update
.. code:: yaml | ||
|
||
LambdaFunction: | ||
Condition: SomeCondition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would skip the example because Conditions is not supported. Examples are useful for things we actually support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair. Will remove
======================== ======================== ======================== | ||
Property Name Intrinsic(s) Supported Reaons | ||
======================== ======================== ======================== | ||
Handler Ref Only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not true. Handler, Runtime, Description, MemorySize, Timeout - We support all intrinsics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I tested this, but must have been doing something else. Will update to reflect what is actually supported
KmsKeyArn All | ||
DeadLetterQueue All | ||
DeploymentPreference All | ||
AutoPublishAlias Ref Only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be precise: Ref of a CloudFormation Parameter
Reason: Alias resource created by SAM uses a LogicalID <FunctionLogicalId+AliasName>. So SAM either needs a string for alias name, or a Ref to template Parameter that SAM can resolve into a string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
StageName All | ||
DefinitionUri All | ||
DefinitionBody All | ||
CacheClusterEnabled Ref Only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All for CacheClusterEnabled & CacheClusterSize
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
======================== ======================== ======================== | ||
Name All | ||
StageName All | ||
DefinitionUri All |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DefinitionUri also has Bucket/Key variant like CodeUri. Can you mention that as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
This includes Event structure and Resource Properties.
Updated based on feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
No description provided.