Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update properties in schema with new docs #3026

Merged
merged 5 commits into from
Mar 14, 2023

Conversation

aaythapa
Copy link
Contributor

@aaythapa aaythapa commented Mar 14, 2023

Issue #, if available

N/A

Description of changes

Updated schema by adding docs for new properties

Description of how you validated changes

make schema

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aaythapa aaythapa marked this pull request as ready for review March 14, 2023 21:05
@aaythapa aaythapa requested a review from a team as a code owner March 14, 2023 21:05
@aaythapa
Copy link
Contributor Author

aaythapa commented Mar 14, 2023

Note: had to change class name SourceReference to SourceReferenceProperties since having the same class name causes type errors. This causes the compatibility check to fail but it shouldn't matter (please let me know if i'm wrong)

@aaythapa aaythapa changed the title chore: update schema with new docs chore: update properties in schema with new docs Mar 14, 2023
@aahung
Copy link
Contributor

aahung commented Mar 14, 2023

Note: had to change class name SourceReference to SourceReferenceProperties since having the same class name causes type errors. This causes the compatibility check to fail but it shouldn't matter (please let me know if i'm wrong)

#3027

@aahung
Copy link
Contributor

aahung commented Mar 14, 2023

Since "Update branch" feature is gone, you probably need manual local merge to make the check pass after #3027 merged

@aahung
Copy link
Contributor

aahung commented Mar 14, 2023

Since "Update branch" feature is gone, you probably need manual local merge to make the check pass after #3027 merged

false, it is not gone

@aaythapa aaythapa enabled auto-merge March 14, 2023 22:36
@aaythapa aaythapa added this pull request to the merge queue Mar 14, 2023
@hoffa hoffa removed this pull request from the merge queue due to a manual request Mar 14, 2023
@aaythapa aaythapa merged commit 90d7119 into aws:develop Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants