Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve schema pass-through handling #3056

Merged
merged 14 commits into from
Mar 23, 2023
Merged

feat: improve schema pass-through handling #3056

merged 14 commits into from
Mar 23, 2023

Conversation

hoffa
Copy link
Contributor

@hoffa hoffa commented Mar 23, 2023

Issue #, if available

Description of changes

Follow-up to #3055; improving how we handle pass-throughs.

I realized we shouldn't typically use the CloudFormation documentation at the pass-through top-level, as the SAM documentation often includes useful SAM-specific information about the property (e.g. how it interacts with others).

So instead, we get the schema from CloudFormation, but use the documentation from SAM.

Description of how you validated changes

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hoffa hoffa marked this pull request as ready for review March 23, 2023 22:35
@hoffa hoffa requested a review from a team as a code owner March 23, 2023 22:35
@hoffa hoffa marked this pull request as draft March 23, 2023 22:36
@hoffa hoffa marked this pull request as ready for review March 23, 2023 23:43
@hoffa hoffa changed the title feat: more pass-through support in schema feat: improve schema pass-through handling Mar 23, 2023
@hoffa hoffa merged commit a28afd4 into aws:develop Mar 23, 2023
@hoffa hoffa deleted the more-passthroughs branch March 23, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants