Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove description in favor of markdownDescription #3068

Merged
merged 3 commits into from
Mar 27, 2023
Merged

chore: remove description in favor of markdownDescription #3068

merged 3 commits into from
Mar 27, 2023

Conversation

hoffa
Copy link
Contributor

@hoffa hoffa commented Mar 27, 2023

Issue #, if available

Description of changes

Some schema cleanup; gets rid of description from SAM properties, in favor of only markdownDescription. description also isn't explicitly Markdown, so using it there can produce weird results.

The CloudFormation documentation so far doesn't include description either, so now it's consistent everywhere.

Description of how you validated changes

Checked it still works as expected in VS Code.

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hoffa hoffa marked this pull request as ready for review March 27, 2023 22:19
@hoffa hoffa requested a review from a team as a code owner March 27, 2023 22:19
@hoffa hoffa enabled auto-merge (squash) March 27, 2023 22:24
@hoffa hoffa merged commit f55b9a5 into aws:develop Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants