Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make add_transform_test.py always match expected output #3195

Merged
merged 7 commits into from
Jun 1, 2023
Merged

feat: make add_transform_test.py always match expected output #3195

merged 7 commits into from
Jun 1, 2023

Conversation

hoffa
Copy link
Contributor

@hoffa hoffa commented Jun 1, 2023

Issue #, if available

Description of changes

So far the script didn't always generate the correct output as we kept using (from perspective of transform) the default region.

This should now match what the transform tests do, so it should always pass the tests without hacks.

Description of how you validated changes

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hoffa hoffa changed the title chore: add more SFN transform tests fix: make add_transform_test.py always match expected output Jun 1, 2023
@hoffa hoffa marked this pull request as ready for review June 1, 2023 17:34
@hoffa hoffa requested a review from a team as a code owner June 1, 2023 17:34
@hoffa hoffa changed the title fix: make add_transform_test.py always match expected output feat: make add_transform_test.py always match expected output Jun 1, 2023
@hoffa hoffa merged commit fd19feb into aws:develop Jun 1, 2023
8 checks passed
@hoffa hoffa deleted the sfn-transform-tests branch June 1, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants