Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: json schema docs update #3256

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Conversation

ssenchenko
Copy link
Contributor

Issue #, if available

Description of changes

Description of how you validated changes

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ssenchenko ssenchenko requested a review from a team as a code owner July 13, 2023 19:32
@ssenchenko ssenchenko changed the title chore: json schema update chore: json schema docs update Jul 13, 2023
@hoffa
Copy link
Contributor

hoffa commented Jul 13, 2023

I'm suspecting the failures have to do with the regressions in jsonschema, e.g. python-jsonschema/jsonschema#1124. Also got related issue in aws-actions/setup-sam#80.

The tests that are failing are all dead code IIRC, so we should be able to remove them, including the runtime dependency on jsonschema (we still use it during schema validation tests though).

@hoffa
Copy link
Contributor

hoffa commented Jul 13, 2023

I created #3257 which removes the failing tests altogether.

@ssenchenko
Copy link
Contributor Author

Thank you @hoffa !

@ssenchenko ssenchenko merged commit 8b4a9cc into aws:develop Jul 13, 2023
8 checks passed
@ssenchenko ssenchenko deleted the chore-schema branch July 13, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants